Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds.glmSLMA needs more tests to catch potential errors in v6.0 #107

Open
tombisho opened this issue Feb 13, 2020 · 3 comments
Open

ds.glmSLMA needs more tests to catch potential errors in v6.0 #107

tombisho opened this issue Feb 13, 2020 · 3 comments
Milestone

Comments

@tombisho
Copy link
Contributor

At the moment I don't think there are tests for:

  • offsets parameter
  • weights parameter
  • the different ways of expressing a model formula, that is:
    • 'BMI ~ age, data = 'D'
    • D$BMI ~D$age
    • BMI_vector ~ age_vector where the variables are not in a dataframe but in separate vectors
  • formulae with a + 1 or + 0

I think this would help trap potential errors

@tombisho
Copy link
Contributor Author

This is probably also true for ds.glm, and will be true for ds.lmerSLMA and ds.glmerSLMA

@tombisho
Copy link
Contributor Author

Offsets and weights should be tested as standalone vectors and as part of the dataframe

@StuartWheater
Copy link
Member

Sorry for the delay in responding. Would you regard the current level of testing adequate to proceed with the release of v6.0?

@StuartWheater StuartWheater added this to the v6.4 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants