Skip to content

Commit a4ab31b

Browse files
authored
Finalize release workflow (#381)
finalized release workflow
1 parent 80b2486 commit a4ab31b

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,12 @@ jobs:
120120
ASTRA_DB_API_ENDPOINT: ${{ secrets.ASTRA_DB_API_ENDPOINT }}
121121
run: make test
122122

123-
# TODO restore integration tests for final
124-
# - name: Run integration tests
125-
# env:
126-
# ASTRA_DB_APPLICATION_TOKEN: ${{ secrets.ASTRA_DB_APPLICATION_TOKEN }}
127-
# ASTRA_DB_API_ENDPOINT: ${{ secrets.ASTRA_DB_API_ENDPOINT }}
128-
# HEADER_EMBEDDING_API_KEY_OPENAI: ${{ secrets.HEADER_EMBEDDING_API_KEY_OPENAI }}
129-
# run: make test-integration
123+
- name: Run integration tests
124+
env:
125+
ASTRA_DB_APPLICATION_TOKEN: ${{ secrets.ASTRA_DB_APPLICATION_TOKEN }}
126+
ASTRA_DB_API_ENDPOINT: ${{ secrets.ASTRA_DB_API_ENDPOINT }}
127+
HEADER_EMBEDDING_API_KEY_OPENAI: ${{ secrets.HEADER_EMBEDDING_API_KEY_OPENAI }}
128+
run: make test-integration
130129

131130
pre-release-unit-lowest-python:
132131
needs:
@@ -190,16 +189,12 @@ jobs:
190189
name: dist
191190
path: dist/
192191

193-
# TODO: retarget prod PyPI (remove 'repository-url' and skip-existing)
194192
- name: Publish package distributions to PyPI - TEST FOR NOW
195193
uses: pypa/gh-action-pypi-publish@release/v1
196194
with:
197195
packages-dir: dist/
198196
verbose: true
199197
print-hash: true
200-
repository-url: https://test.pypi.org/legacy/
201-
# This setting ONLY IN CI AND ON TEST PYPI! See https://github.com/pypa/gh-action-pypi-publish#tolerating-release-package-file-duplicates
202-
skip-existing: true
203198
# TODO determine whether to enable attestations later on, and how
204199
attestations: false
205200

@@ -229,18 +224,12 @@ jobs:
229224
name: dist
230225
path: dist/
231226

232-
- name: Create release (TMP draft, prerelease)
227+
- name: Create release on Github
233228
uses: ncipollo/release-action@v1
234229
with:
235230
artifacts: "dist/*"
236231
token: ${{ secrets.GITHUB_TOKEN }}
237-
# TODO: restore to false
238-
draft: true
239232
generateReleaseNotes: true
240-
# TODO: restore `v${{ needs.build.outputs.version }}`
241-
tag: test-v${{ needs.build.outputs.version }}
242-
# TODO: restore (no 'test-'')
243-
name: "test-Release v${{ needs.build.outputs.version }}"
233+
tag: v${{ needs.build.outputs.version }}
234+
name: "Release v${{ needs.build.outputs.version }}"
244235
commit: ${{ github.sha }}
245-
# TODO: restore false
246-
prerelease: true

0 commit comments

Comments
 (0)