-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest: Handle error messages from the server #1047
Comments
We do have this already but that's not what you're looking for? Lines 312 to 319 in e98e8e5
|
Hmm, right. It's a bit generic and w/o a custom message, but should do the trick. |
I mean, you could also add a way to set a custom error message for those (but you would have to handle translations). I'm just not quite sure what you want to implement yet. :D |
E.g. I want the backend to check if value updates are just white space changes and omit them to reduce noise like this: But this could result in edge cases where the server decides that a suggestion isn't post-worthy and therefore won't generate a PR. Since this is different than a straight up error, I thought we might want to cover this via a message. But since you brought up the issue of translating these messages, I think we could just use the generic error. :D I also have other ideas, e.g. withholding PRs that contain the string "gmail"... :D |
Oh btw, I think you've suggested this before and I disagreed but I have now changed my mind on this. Let's force-format everything: datenanfragen/data#2165, datenanfragen/data#2166
Wouldn't be too bad. You would just return a translation key from the server. shrug
Oh, that's a good idea. But unfortunately: You'd need a way to have the user confirm that this really is the company's email and not theirs. |
I want the backend to be able to reject suggestions with a message. Before implementing this in the backend, I will implement support for it in the frontend.
This will allow us to filter stuff in the backend (e.g. white space changes) to reduce noise in the data repo, without confusing users.
The text was updated successfully, but these errors were encountered: