Time for a new release?

[vit-zikmund]

Hello Datopian folks!

I just stumbled upon this great project and hit a blocker in the 0.5.0 release, that's already fixed.
I need to target a private AWS-like object storage, but the endpoint setting is missing from the docker image. This year even boto3 got upgraded to read the AWS_ENDPOINT_URL env var to override it, but the one included is too old.

I see there's been a couple fixes here and there in the last two years from the 0.5.0 release. Would that make sense to carve out a new one? 🙂 I sure can build the stuff myself (thank you for that - making this nice tool opensource), but wanted to ask, before I start the plumbing process.

Thank you so much! 😉

[rufuspollock]

@vit-zikmund good point and sorry for the slow reply. We definitely should do a new release. If you also have patches or contributions you would like to make PRs are welcome.

@anuveyatsu can we push out a new release of this soon?

[rufuspollock]

@anuveyatsu @demenech tagging you here if we can get a new release out (and/or enable @athornton to push releases).

[demenech]

hello @rufuspollock

I do not have the necessary permissions.

@anuveyatsu perhaps you could give me and @athornton higher privilege?

[athornton]

The problem isn't on the GitHub side, it's on the uploading to PyPi side, if I remember correctly.

Someone who's an admin on the PyPi Datopian account could add me and @vit-zikmund , or (I think) they could go through the process to link the GH repository with PyPi as a trusted publisher:

https://docs.pypi.org/trusted-publishers/adding-a-publisher/

That's probably both easier and more secure since no one would have to grant additional PyPi privileges. Then we could just bake the PyPi upload into the Github Actions for doing a release.

[demenech]

hello @athornton

letting you know that I have been given the privilege, so I believe I can unblock this now, will try to do it between the end of my day today and tomorrow

[vit-zikmund]

Oh this is sweet! Could I get to squeeze in one little, but rather important security improvement for the github auth?

[demenech]

hello @athornton

The trusted publisher has been added. Can you try it out, please? And is there anything else that I have to do?

[athornton]

Thanks. I'll see what I can do with the CI and whether I can get it to push.

[athornton]

Turns out 3.13 support is going to be a little harder than I expected, so I won't be adding that right now. I am adding uv as a pip replacement, because it's much, much faster, and that matches what we did at Rubin.

We should think about what branches should build ghcr containers, too. Currently it's "tickets/*" and releases, which match what we do at Rubin, but the naming of ticket branches is a very specific-to-Rubin convention. If there's something else you prefer we can easily change that.

One thing I think you could do, @demenech , is give @vit-zikmund whatever permissions on this repo I've got. He's been doing most of the most recent work.

[athornton]

Would folks who aren't me, using Docker containers, please try out the image ghcr.io/datopian/giftless:tickets-DM-42598 and ensure it's working as expected? I am going to put it in my dev environment for the afternoon, and then try it in prod.

Assuming it looks good, I'll merge it up to main and then cut a 0.6.0 release early next week. That release should trigger the PyPi upload, and hopefully everything works and then we can announce Version 0.6.0 for real. If not, well, there will be some fast follower releases until we DO get it pushing smoothly to PyPi.

If Datopian wants to keep hosting at Docker Hub, we'll need to put a push token in the secrets for the repository or the organization and change the CI slightly. Myself, I feel like GitHub is likely to survive longer and in better shape than Docker-the-company and it's probably just appropriate for Datopian, when they announce the new release, to point out that the host for the docker containers has moved.

[anuveyatsu]

Hi @athornton @vit-zikmund thank you for the effort into making the new release possible 🙏🏼 we just invited @vit-zikmund as maintainer of this repo 👍🏼

I don't think we have any constraints regarding the location of the container registry, so a GitHub-based option should work perfectly fine.