Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch operation fails if optional hash_algo key is used #99

Open
vali-um opened this issue Feb 8, 2022 · 1 comment
Open

batch operation fails if optional hash_algo key is used #99

vali-um opened this issue Feb 8, 2022 · 1 comment

Comments

@vali-um
Copy link

vali-um commented Feb 8, 2022

Hi,

some time ago git for windows started using the hash_algo key in their git-lfs batch requests.
This leads to an unspecific error with giftless

HTTP/1.1 422 UNPROCESSABLE ENTITY
{"message": "422 Unprocessable Entity: The request was well-formed but was unable to be followed due to semantic errors."}

The key is optional according to the git-lfs docs, see https://github.com/git-lfs/git-lfs/blob/main/docs/api/batch.md#requests

I've created a small patch to make it work but without any extra error handling if a client would request another hash algorithm. schema_hash_algo.txt

I hope someone can make use of this.

Cheers, Valentin

@connorjclark
Copy link
Contributor

This patch works with the latest pypi, thanks!

BTW this was not needed when using the latest main code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants