Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale installation instructions #150

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Remove stale installation instructions #150

merged 1 commit into from
Mar 7, 2024

Conversation

connorjclark
Copy link
Contributor

This should be main now, but it wasn't necessary for me in a fresh virtual env so guess can be removed now.

@connorjclark
Copy link
Contributor Author

connorjclark commented Mar 6, 2024 •
edited
Loading

Actually this is maybe still needed? Don't know what error it may refer to.

export FLASK_APP=giftless.wsgi_entrypointflask run
 * Serving Flask app "giftless.wsgi_entrypoint"
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
Usage: flask run [OPTIONS]

Error: Could not import "giftless.wsgi_entrypoint".

I tried https://raw.githubusercontent.com/datopian/giftless/main/requirements/main.txt instead, but the error still occurs

EDIT: I got around this error but kept having other issues, until I decided to use the latest main code instead of what is on pypi (pip install git+https://github.com/datopian/giftless.git@main).

athornton
athornton approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. We shouldn't need it when installing from main.

Datopian is still working out how to do PyPi and new container builds/pushes. Hopefully that gets sorted out soon.

@athornton athornton merged commit 8c3169d into datopian:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athornton athornton athornton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjclark @athornton