Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush fs access on Drop #3

Open
yoshuawuyts opened this issue Apr 8, 2018 · 2 comments
Open

flush fs access on Drop #3

yoshuawuyts opened this issue Apr 8, 2018 · 2 comments

Comments

@yoshuawuyts
Copy link
Contributor

We should probably implement the Drop trait so when we destroy the rad instance, we can call the fs.sync (forgot the name) method to make sure everything has been persisted to disk.

@spacejam warned we're opening us up for trouble if we don't ensure this is called 🙏

@spacejam
Copy link

spacejam commented Apr 8, 2018

This is an area that is pretty hard to get right:
https://danluu.com/file-consistency/

It's lower priority if your stuff doesn't need to actually be on the machine after an abrupt restart, but to the extent that your data can't be found elsewhere or recomputed from something that can be, this is worth thinking about.

I'm happy to help with this :)

@yoshuawuyts
Copy link
Contributor Author

@spacejam ohh, yeah that link is real helpful. I think we definitely will want to handle data persistance as well as possible - help would be real good with this! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants