Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work for Google Drive Embeds (included a codepen example) #254

Open
ufo2mstar opened this issue Oct 21, 2017 · 1 comment
Open

Comments

@ufo2mstar
Copy link

Hi @davatron5000 ,
Thanks for the cool plugin 👍 saved me some development time on my blog...
But am facing issues with google drive embeds. Here is the codepen example of my issue:
https://codepen.io/ufo2mstar/pen/EwMMxz

PS: If I may proffer a suggestion; the codepen issue guideline is a good idea.. a lesser threshold for entry would be a forkable working example showing how you wanted us bug loggers to put forward the example would make it easier on us 😄 maybe you can even remodel my own example if you like it..
Cheers!

@ufo2mstar ufo2mstar changed the title Does not work for Google Drive Embeds Does not work for Google Drive Embeds (included a codepen example) Oct 21, 2017
@ufo2mstar
Copy link
Author

Update, I tried the the customSelector option that works.. hope this helps to fix the problem
https://codepen.io/ufo2mstar/pen/EwMMxz

// does not work
$('iframe[src*="drive"]').parent().fitVids();
// does work 
$("#vid_div").fitVids({ customSelector: "iframe[src^='https://drive.google.com']"});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant