Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff is only working for commited changes not 'File Saved' #56

Open
lldelisle opened this issue Oct 21, 2022 · 3 comments
Open

Diff is only working for commited changes not 'File Saved' #56

lldelisle opened this issue Oct 21, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@lldelisle
Copy link

First of all, I love your extensions. Thank you so much for this work.
I am not super at ease with visual studio but what I like to do is:

  • Modify the workflow in the workflow editor of usegalaxy.org
  • Download the workflow
  • Inspect the changes before commiting
    It seems that I cannot do that. I tried:
    Peek 2022-10-21 10-33
    Also, I don't know if it is possible to include that in the source control. This would be amazing.
@davelopez
Copy link
Owner

Thank you!
Ohh I see, the File Saved History feature in the Timeline was introduced in VSCode after I added the workflow clean compare feature so it is not supported right now. It is probably just trying to find a git reference that doesn't really exist.

I'll have a look and see if I can make it work! Thanks for the report!

@davelopez davelopez added the enhancement New feature or request label Oct 21, 2022
@lldelisle
Copy link
Author

For info, it raises an error with files which are 'added' not commited:
image

@davelopez davelopez added the bug Something isn't working label Oct 21, 2022
@davelopez
Copy link
Owner

I was investigating this recently because now (also) real commits in the timeline cannot be processed for comparison. I found out that the VSCode internal API changed and we can no longer access the necessary information from the timeline. So we will need to wait for a solution in microsoft/vscode#177319 for this to work... 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants