Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment cannot handle plus sign in filename #47

Open
hackerb9 opened this issue Jan 3, 2017 · 4 comments
Open

Attachment cannot handle plus sign in filename #47

hackerb9 opened this issue Jan 3, 2017 · 4 comments

Comments

@hackerb9
Copy link

hackerb9 commented Jan 3, 2017

It turns the plus sign into a space. To replicate:

  1. Create a document in Open Office and save it as "foo+bar"
  2. File → Send → Email Document
  3. Immediately a notification pops up from Gnome Gmail that it could not find the file "foo bar"

I do not experience this bug when I rename the file "foo&bar".

@davesteele
Copy link
Owner

This is actually intentional. URL decoding maps pluses to spaces. Mailto URLs in the wild often count on the plus being interpreted as a space.

@hackerb9
Copy link
Author

hackerb9 commented Jan 5, 2017

So, is this a bug in Open Office then? They should be percent encoding plus signs in filenames?

@davesteele
Copy link
Owner

I believe so. More specifically, the script senddoc.sh.

Though gnome-gmail's handling of escapes could use a closer look.

@hackerb9
Copy link
Author

hackerb9 commented Jan 5, 2017

I will file a bug with Libre Office, it seems they do try to percent encode the filename, but the program /usr/lib/libreoffice/uri-encode doesn't transmogrify plus signs.

In the meantime, and perhaps to avoid future problems, would it be possible for GG to do a double check for an incorrectly URI encoded filename before popping up the "File not found" error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants