Add support for tsconfig extends #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! It's late here so I'll take a look tomorrow. Thanks :) |
davestewart
requested changes
Nov 25, 2021
|
OK, linting now added so you'll want to merge and run |
IanVS
force-pushed
the
parse-tsconfig
branch
from
4564abb
to
1844878
Compare
|
Updated to address linting issues |
davestewart
approved these changes
Nov 25, 2021
|
No idea what these errors are about. Any ideas? EDIT: seems to be a build pipeline permissions thing. I ran the checks locally and it's all good, so going to merge 👍 |
davestewart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the native typescript utilities for reading and parsing a config file, which means that comments and trailing commas are supported, as well as extending from another config.
I needed to break out a helper function to log messages, since the parsing is slightly different between package.json and config files now, but they can share the same error handling, I think.
I also created a few basic tests for loading config files with comments and commas, as well as extending from other configs. Let me know if you'd like to see more.
Closes #28
Closes #30