Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device-Name "null" #3

Open
DrAzraelTod opened this issue Dec 16, 2016 · 2 comments
Open

Device-Name "null" #3

DrAzraelTod opened this issue Dec 16, 2016 · 2 comments

Comments

@DrAzraelTod
Copy link

if connected to a device, then you can give it a name that is used remotely.
But the global name isn't defined, what results in syncthing (web) displaying the ID instead on prompts - while some frontends (i.e. the other android one) show errors.

So the other android-client displays notifications like "Syncthing Device null want's to share Directory foobar"

@davide-imbriaco
Copy link
Owner

this is weird... it should use the android model as device name

private  String getDeviceName() {
    String manufacturer = Build.MANUFACTURER;
    String model = Build.MODEL;
    if (model.startsWith(manufacturer)) {
        return capitalize(model);
    } else {
        return capitalize(manufacturer) + " " + model;
    }
}

I'll add a non-null default. Could you tell me more about your test device, and (if you know) the protocol messages where the device name field is null?

@DrAzraelTod
Copy link
Author

Well, the device i tested on was a Nexus 6p with googles current Android 7.1.1 Beta build

As for protocol messages - i don't have those and i just deinstalled your tool

Further: model-name sounds like a bad Idea to me. My wife and i both had the same phone, as do my parents. I find it plausible that people would want to connect multiple similar devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants