-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending binary data in a message #244
Comments
Correct, the client does not currently support receiving or sending binary data. Its actually something I've been looking into recently to add. I'll update if I make any progress on this feature |
Hi, was there any progress on this issue? My use-case involves sending audio samples so would be great to not have to pay the JSON serialization/deserialization cost. |
@samrat something is in the works. I'll update back here when progress is made |
#273 added support to the
|
Issue:
I'm trying to send some messages to the server that contain binary data instead of JSON. I might be missing something, but so far it looks to me like the framework doesn't support sending an event with anything other than JSON as a payload.
Possible solution:
I took an initial pass at what might be needed to support sending binary data using the
URLSessionWebSocketTask.Message.data(Data)
function. Unfortunately, it looks to me like this would require a new/updated implementation ofPush
because the current one only allows payloads of type[String : Any]
to be passed in for transport. Can you think of a more straightforward approach?I believe sending events with binary data payloads is a pretty commonly used Phoenix feature, so I think this would add general value to the framework. I'll keep working on a possible solution on my end, but curious to hear your thoughts @dsrees.
The text was updated successfully, but these errors were encountered: