Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrary to documentaion, zoom needs to be used with zoomX and zoomY #58

Open
longtengz opened this issue Jul 24, 2023 · 1 comment
Open
Labels
bug Something isn't working checking

Comments

@longtengz
Copy link

longtengz commented Jul 24, 2023

We were previously using vue2-infinite-viewer (a version prior to this change ea62972). And we only need to set zoom.

But when we update to the newest version of vue3-infinite-viewer (which has the zoomX and zoomY change), setting zoom alone does not work as the style shows that scale is still (1, 1) which contradicts with our value 0.75 for zoom.

After some digging, I saw this change ea62972 , and found that upon rendering it's using zoomX=1, zoomY=1. So I pass in zoomX=0.75and zoomY=0.75 alongside with zoom=0.75, and voila it works.

However, when reading the documentation it clearly says do not use them together,

If you use the zoom property, don't use the zoomX and zoomY properties.

so I think there's something wrong with the implementation.

@daybrush daybrush added the bug Something isn't working label Jul 29, 2023
@daybrush
Copy link
Owner

@longtengz
I checked and it works fine.

It is my intention to use only zoom or only (zomX, zoomY).

Is there a demo I can check out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checking
Projects
None yet
Development

No branches or pull requests

2 participants