Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring_repeated_field_ordering can't always be combined with ignoring_field_paths #12

Open
mdepinet opened this issue Sep 28, 2023 · 2 comments

Comments

@mdepinet
Copy link

ignoring_repeated_field_ordering works by sorting values based on their string representation. In order to work with ignoring_field_paths, it would need to omit ignored fields from the string representation before ordering.

That said, currently a mismatch can shift the expected list leading to more apparent diffs than real diffs, so maybe it makes more sense to iteratively compare each value from actual to each value in expected that hasn't already been matched.

@mdepinet
Copy link
Author

I opened a PR to fix this if you have time to review: #13

@mdepinet
Copy link
Author

For anyone who comes across this in the future, I've created a new repo here: https://github.com/mdepinet/hamcrest-proto

Contributions welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant