use tailwind css instead of picocss #33
Open
+1,557
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliYar-Khan
force-pushed
the
migration/picocss-to-tailwindcss
branch
from
eef26bb to
1342914
Compare
Signed-off-by: Ali Yar Khan <[email protected]>
Sign Signed-off-by: Ali Yar Khan <[email protected]>
AliYar-Khan
force-pushed
the
migration/picocss-to-tailwindcss
branch
from
a69ef93 to
853acc8
Compare
|
/claim #5 |
|
@nkkko please take a look here to my work and let me know if there any changes required |
|
@nkkko Please review the changes and let me know if anything is unclear. Will really appreciate your feedback. |
|
Sorry for the late reply, have been busy. The interface is messed up, especially buttons, see img: It still loads Pico? |
|
I will look into these not sure why it is happening !!! |
|
@AliYar-Khan I’ve updated main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward. |
|
@mojafa I did updated it |
|
@AliYar-Khan looks like we still have |
|
|
|
@mojafa yes I am not sure why it is there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference(s):
Fixes #5
/claim #5
Migration to Tailwind CSS
had to install tailwind package as dev dependency and on start of server generate the CSS from main.css to tailwind.css
Also the main.css is also convert to tailwind classes and use the utility provided by tailwind to apply them. Reason for doing this was because in main.js file we have used the class name to add event listeners on the elements like button and it could have break the functionality.