Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipleStatements vs multiple-statements #303

Open
maligree opened this issue Sep 3, 2015 · 4 comments
Open

multipleStatements vs multiple-statements #303

maligree opened this issue Sep 3, 2015 · 4 comments
Assignees

Comments

@maligree
Copy link

maligree commented Sep 3, 2015

The readme first mentions setting multiple-statements: true and then sets multipleStatements: true. This is slightly confusing, i.e. it made me check both ways to see if perhaps the lib works with both camelCase and hyphenated attributes.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@wzrdtales
Copy link
Member

That is indeed a bit confusing.

To note, in the case of MySQL, it is always true if it applies to node-mysql:

https://github.com/felixge/node-mysql/#multiple-statement-queries

I flag this as a note to rework this part of the documentation.

Thank you for reporting this issue!

@wzrdtales wzrdtales self-assigned this Sep 3, 2015
@jacob-israel-turner
Copy link

This has not been resolved, the documentation is still ambiguous. For anyone who comes across this, I tested both multiple-statements: true and multipleStatements: true, and the correct usage is multipleStatements: true.

@wzrdtales
Copy link
Member

@jacob-israel-turner Feel free to shoot out a PR and you will be one having this fixed :) https://github.com/db-migrate/english-docs

@jacob-israel-turner
Copy link

Done!

db-migrate/english-docs#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants