Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum dbt-adapters requirement to 1.9.0 #10998

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

QMalcolm
Copy link
Contributor

Resolves #10996

Problem

In dbt-core we've made a switch from an environment variable for gating microbatch functionality to a project flag (#10799). In dbt-adapters we've done likewise (dbt-labs/dbt-adapters#323). For everything to work properly, we need depend on those changes in dbt-adapters, which will go out in 1.12.0

Solution

bump dbt-core's requirement spec for dbt-adapters to have a minimum of 1.12.0

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

This is needed for dbt-core + dbt-adapters to work properly in regards to
the microbatch project_flag/behavior flag `require_batched_execution_for_custom_microbatch_strategy`
@QMalcolm QMalcolm requested a review from a team as a code owner November 13, 2024 18:08
@cla-bot cla-bot bot added the cla:yes label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (e9a2b54) to head (a574383).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10998      +/-   ##
==========================================
+ Coverage   89.05%   89.07%   +0.01%     
==========================================
  Files         183      183              
  Lines       23626    23626              
==========================================
+ Hits        21040    21044       +4     
+ Misses       2586     2582       -4     
Flag Coverage Δ
integration 86.37% <ø> (+0.01%) ⬆️
unit 62.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.79% <ø> (ø)
Integration Tests 86.37% <ø> (+0.01%) ⬆️

@QMalcolm
Copy link
Contributor Author

Tests won't pass until we do the dbt-adapters release

@QMalcolm QMalcolm merged commit 6e1f64f into main Nov 13, 2024
60 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--bump-minimum-dbt-adapters-to-1.9.0 branch November 13, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump minimum dbt-adapters version to 1.9.0
2 participants