Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to handle moving from microbatch environment variable to behavior flag #167

Closed
wants to merge 2 commits into from

Conversation

QMalcolm
Copy link
Contributor

resolves #N/A

Problem

dbt-adapters and dbt-core are moving from using an environment variable for gating microbatch functionality to a behavior flag (dbt-labs/dbt-adapters#323, dbt-labs/dbt-core#10799). Additionally, dbt-adapters is adding more test stubs around this, and we wan to use those test stubs

Solution

Use the test stubs provided by dbt-adapters to test the switch from environment variable for gating microbatch functionality to a behavior flag.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm force-pushed the qmalcolm--move-to-microbatch-behavior-flag branch from 583a46b to 911fb19 Compare November 8, 2024 00:06
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Nov 8, 2024

Closing because this is no longer going to be merged, moving back to a POC Draft PR (#173)

@QMalcolm QMalcolm closed this Nov 8, 2024
@mikealfare mikealfare deleted the qmalcolm--move-to-microbatch-behavior-flag branch November 9, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant