Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support connection options #59

Open
3 tasks done
sdebruyn opened this issue Apr 11, 2024 · 0 comments
Open
3 tasks done

[Feature] Support connection options #59

sdebruyn opened this issue Apr 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sdebruyn
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-postgres functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Some Postgres connections require extra connection options. Add the configuration parameter options in the profile to support those use cases.
The parameter is documented in the Postgres docs.

Describe alternatives you've considered

No response

Who will this benefit?

dbt Cloud is using an outdated version of libpq which does not support SNI. Some providers rely on SNI and have built workarounds using connection options. Even if at some point dbt Cloud updates its libpq version (it should), extra connection options might still be useful.
An example is neon.tech, see this documentation page

Are you interested in contributing this feature?

Yes, if you confirm that you'd be willing to have this feature so that I don't put effort into a PR which you won't accept.

Anything else?

psycopg2 just accepts this like any other connection parameter. After adding the options as a string in the PostgresCredentials, this should be added in the kwargs right before this line.

@sdebruyn sdebruyn added enhancement New feature or request triage labels Apr 11, 2024
@amychen1776 amychen1776 removed the triage label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants