Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the semicolon semantics for indexes while respecting other bug fix. #97

Merged
merged 2 commits into from
May 15, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented May 15, 2024

resolves #85
docs dbt-labs/docs.getdbt.com/#

Problem

image

Reprex now added as test and replicated locally!

@mikealfare shared this lovely context, re the comment linked in the issue ticket (here). We removed a ; at the postgres__get_create_index_sql macro to solve a different problem sending up empty queries when getting this merged:

We do not appear to be updating cache for MV functionality like drops, renames, adds which is causing catalog mismatch errors in runs especially between MV's that are dependent on each other

This however was incomplete as a solution because we needed to only leave off the last ; from various index create/alter statements.

Solution

image

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this May 15, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner May 15, 2024 01:43
@cla-bot cla-bot bot added the cla:yes label May 15, 2024
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog, otherwise it looks good.

@VersusFacit VersusFacit merged commit e23d0a7 into main May 15, 2024
18 checks passed
@VersusFacit VersusFacit deleted the ADAP-85/fix_multiple_indexes branch May 15, 2024 03:46
@jtcohen6
Copy link
Contributor

FYI @VersusFacit - We need to backport this fix for inclusion in v1.7.x + v1.8.x, because this was a regression introduced in v1.7.14. I don't believe we have the backport workflow set up in this repo yet, so we either need to backport manually or set up that workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Materialized view with multiple indexes errors
3 participants