Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit sha from release inputs #69

Open
Tracked by #87
emmyoop opened this issue Feb 23, 2023 · 0 comments
Open
Tracked by #87

Remove commit sha from release inputs #69

emmyoop opened this issue Feb 23, 2023 · 0 comments

Comments

@emmyoop
Copy link
Member

emmyoop commented Feb 23, 2023

Remove the commit sha from release inputs. We should always release the HEAD of the branch we release from.

We can never release anything except HEAD. If we tried, we end up merging in version and changelog updated into HEAD and then using the new HEAD with the updates included.

Example

- commit 003 HEAD
- commit 002
- commit 001

If we entered to release commit 001, the version bump and changelog generation would take place, we would merge those changes back in to the branch and now have (assuming no conflicts)

- commit 004 HEAD
- commit 003 
- commit 002
- commit 001

And would release commit 004 which would _include 002 which is not desirable. Removing commit sha as an input removes any confusion that this may be possible.

This will involve removing input from pre-release, changing logic to use HEAD in the build step, and updating core and all adapters to no longer take the commit sha as an input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant