[CLEANUP] Another pass at switching usages of model
to semantic_manifest
#118
Labels
House keeping
Not a feature, not a bug, just some house keeping
In the before times, pre March 2023, we referred to
SemanticManifest
s asModel
s. We've taken an initial pass getting a fair number of these moved over, but many remain (Examples: A, B, C, etc).Getting these corrected is slowly becoming harder due to Hyrum's Law. The incorrect usage of the word
model
shows up in class names, function names, function attributes, variables within functions, comments. Some of these are easier to fix than others. For the use ofmodel
in comments and in variables instantiated within a function run have no outside exposure and can be changed without worry. Usage ofmodel
in function names beginning with a_
and parameters of a function starting with a_
are safe to change because they are "private" functions. For function names, parameters to public functions, class names, and public attributes of classes we'll first have to investigateMetricFlow
anddbt-core
to see if these names are depended on. At this time I'm not too worried about third party exposure given that we're in RC of our first version release.Oh this is extra hard because pydantic's
HashableBaseModel
andBaseModel
,SemanticModel
, and the like have valid uses of the wordmodel
and thus a simple "find and replace" cannot be used 🙃The text was updated successfully, but these errors were encountered: