Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Another pass at switching usages of model to semantic_manifest #118

Open
Tracked by #140
QMalcolm opened this issue Jul 14, 2023 · 0 comments
Open
Tracked by #140
Labels
House keeping Not a feature, not a bug, just some house keeping

Comments

@QMalcolm
Copy link
Collaborator

In the before times, pre March 2023, we referred to SemanticManifests as Models. We've taken an initial pass getting a fair number of these moved over, but many remain (Examples: A, B, C, etc).

Getting these corrected is slowly becoming harder due to Hyrum's Law. The incorrect usage of the word model shows up in class names, function names, function attributes, variables within functions, comments. Some of these are easier to fix than others. For the use of model in comments and in variables instantiated within a function run have no outside exposure and can be changed without worry. Usage of model in function names beginning with a _ and parameters of a function starting with a _ are safe to change because they are "private" functions. For function names, parameters to public functions, class names, and public attributes of classes we'll first have to investigate MetricFlow and dbt-core to see if these names are depended on. At this time I'm not too worried about third party exposure given that we're in RC of our first version release.

Oh this is extra hard because pydantic's HashableBaseModel and BaseModel, SemanticModel, and the like have valid uses of the word model and thus a simple "find and replace" cannot be used 🙃

@QMalcolm QMalcolm added the House keeping Not a feature, not a bug, just some house keeping label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
House keeping Not a feature, not a bug, just some house keeping
Projects
None yet
Development

No branches or pull requests

1 participant