Consolidated meta config to use the same models #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
|
Can we do the version bump in this PR? I think it would be safer to merge those together to make sure we don't accidentally release a breaking version without bumping the minor version (in case someone did a patch version bump and released it before we had a chance to release the new minor version). |
4 tasks
…nsolidate_meta_config
…nsolidate_meta_config
courtneyholcomb
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Looks good to me! Just make sure you coordinate will @WilliamDee on the version bump and it should be good to go!
### Description This PR implements the meta config merge behavior described [here](https://docs.getdbt.com/reference/configs-and-properties#combining-configs) and referenced [here](#362). I decided to stack this PR on top to keep it distinct from the other PRs, but I don't intend to merge this one into main directly. I will merge it into its parent branch first. ### Checklist - [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [x] This PR includes tests, or tests are not required/relevant for this PR - [ ] ~~I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)~~ I'm not going to merge this directly into main, so we don't need a separate changelog entry.
Base automatically changed from
Add_meta_to_measures,_entities,_and_dimensions
to
main
November 12, 2024 19:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses this feedback to consolidate the meta config into central models. This is technically a breaking change because some classes have been deleted, but Courtney confirmed that these classes are not being used by dbt-core.
Checklist
changie newto create a changelog entry