Slugify handle empty strings (#912)

* Handle empty strings in slugify macro * update changelog with PR number * fix slugify test * return empty string rather than none --------- Co-authored-by: Andrew Vaccaro <[email protected]>
dbt-labs · Jun 4, 2024 · cb8dd4b · cb8dd4b
1 parent af64dbe
commit cb8dd4b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/integration_tests/tests/jinja_helpers/test_slugify.sql b/integration_tests/tests/jinja_helpers/test_slugify.sql
@@ -1,9 +1,13 @@
 with comparisons as (
+  select '{{ dbt_utils.slugify("") }}' as output, '' as expected
+  union all
+  select '{{ dbt_utils.slugify(None) }}' as output, '' as expected
+  union all
   select '{{ dbt_utils.slugify("!Hell0 world-hi") }}' as output, 'hell0_world_hi' as expected
   union all
   select '{{ dbt_utils.slugify("0Hell0 world-hi") }}' as output, '_0hell0_world_hi' as expected
 )
 
 select * 
 from comparisons
-where output != expected
+where output != expected
diff --git a/macros/jinja_helpers/slugify.sql b/macros/jinja_helpers/slugify.sql
@@ -1,5 +1,9 @@
 {% macro slugify(string) %}
 
+{% if not string %}
+{{ return('') }}
+{% endif %}
+
 {#- Lower case the string -#}
 {% set string = string | lower %}
 {#- Replace spaces and dashes with underscores -#}
@@ -11,4 +15,4 @@
 
 {{ return(string) }}
 
-{% endmacro %}
+{% endmacro %}