Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not_accepted_values test didn'd work with fail_calc: "sum(n_records)" config #860

Open
La1x opened this issue Dec 18, 2023 · 4 comments
Open

Comments

@La1x
Copy link

La1x commented Dec 18, 2023

Describe the feature

Test not_accepted_values should be the same as generic test from original dbt accepted_values which has a n_records column in results:

with all_values as (

    select
        {{ column_name }} as value_field,
        count(*) as n_records

    from {{ model }}
    group by {{ column_name }}

)
...

Who will this benefit?

Anyone who wants to use config: fail_calc: "sum(n_records)" feature, descibed here.

@LarissaSiqueirabp
Copy link

That would be nice

Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 14, 2024
@La1x
Copy link
Author

La1x commented Oct 14, 2024

any update on this issue?

@github-actions github-actions bot removed the Stale label Oct 15, 2024
@Caitlin-Syntax
Copy link

I'd also like this feature! It's strange to me that the default result of the accepted_values test is not the number of affected records, so I always set fail_calc to show that instead. I'd like to be able to do the same for not_accepted_values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants