Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to not_null_proportion test #866

Closed
j-svensmark opened this issue Feb 7, 2024 · 1 comment
Closed

Add filter to not_null_proportion test #866

j-svensmark opened this issue Feb 7, 2024 · 1 comment
Labels
enhancement New feature or request triage

Comments

@j-svensmark
Copy link

j-svensmark commented Feb 7, 2024

Describe the feature

I want to add a filter as an optional argument to the not_null_proportion test.
This is make it possible to use this test in e.g. a partitioned table in BQ with a required filter over a given column.

I made possible implementation in main...j-svensmark:dbt-utils:patch-1 (untested though), though I saw your PR policy doesn't allow PRs without an issue, hence this issue.

@j-svensmark j-svensmark added enhancement New feature or request triage labels Feb 7, 2024
@j-svensmark
Copy link
Author

Ah, just found that the built in where functionality in dbt tests (https://docs.getdbt.com/reference/resource-configs/where) covers this use case, so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant