-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tox #919
Merged
Merged
Add tox #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
reviewed
Jun 11, 2024
emmyoop
commented
Jun 14, 2024
emmyoop
force-pushed
the
er/setup-tox
branch
3 times, most recently
from
July 2, 2024 15:13
0f901aa
to
30bfa75
Compare
emmyoop
commented
Aug 23, 2024
emmyoop
commented
Aug 23, 2024
dbeatty10
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We'll do a follow-up later to remove the CircleCI workflows and just use CI via GitHub Actions.
Related to dbt-labs/dbt-core#10668 |
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #920
resolves #948
Problem
We're using bash to run tests right now and want to standardize on tox so all tests can be run the same, regardless which method is being used for testing.
Solution
/integration_tests/ci/sample.profiles.yml
to/integration_tests
and rename it toprofiles.yml
supported_adapters
var and[testenv:list_supported_adapters]
tox command to be able to determine what env vars to test. This allows the package maintainer to explicitly control what adapters should be tested without inferring it from the profile. This is useful during development or for iterative changes.I did not rewrite the tests to use tox as it was out of scope for this exercise.
Checklist