Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time #6012

Closed
FishtownBuildBot opened this issue Sep 4, 2024 · 0 comments · Fixed by #6117
Closed

[Core] Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time #6012

FishtownBuildBot opened this issue Sep 4, 2024 · 0 comments · Fixed by #6117
Assignees
@gshank @graciegoheen @nataliefiann
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear size: large This change will more than a week to address and might require more than one person

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Sep 4, 2024 •
edited by dbeatty10
Loading

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

Issue: dbt-labs/dbt-core#10234
PR: dbt-labs/dbt-core#10352

On page https://docs.getdbt.com/reference/resource-configs/updated_at add a note that the user may get a warning if the data type of the "updated_at" column does not match the adapter-configured default.
@FishtownBuildBot FishtownBuildBot mentioned this issue Sep 4, 2024
Closed
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Sep 4, 2024
@nataliefiann nataliefiann added the size: large This change will more than a week to address and might require more than one person label Sep 10, 2024
@nghi-ly nghi-ly changed the title Docs Changes Needed from dbt-core Issue #10234 [Core] Docs Changes Needed from dbt-core Issue #10234 Sep 13, 2024
@graciegoheen graciegoheen changed the title [Core] Docs Changes Needed from dbt-core Issue #10234 [Core] dbt-core Issue #10234 - Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time Sep 23, 2024
@nataliefiann nataliefiann mentioned this issue Sep 26, 2024
Merged
3 tasks
@dbeatty10 dbeatty10 changed the title [Core] dbt-core Issue #10234 - Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time [Core] Warn if updated_at field for snapshot is not same datatype as what's returned in snapshot_get_time Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

@graciegoheen graciegoheen

@nataliefiann nataliefiann

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a caution callout for updated_at dbt-labs/docs.getdbt.com
5 participants
@gshank @runleonarun @graciegoheen @FishtownBuildBot @nataliefiann