-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package hub doesn't have OpenGraph tags #1883
Comments
I didn't know anything about OpenGraph so Googled a bit to bootstrap my knowledge. ImplementationHere's my best guess for how to approach this:
The steps above should add both the "description" and "image" tags that are currently missing to the webpage for each package. Verification
Check each of the following:
Example |
Love the suggestion to automatically acquire the I wouldn't consider this fully blocking though, since we could choose something for the description that is immediately available (like some trivial re-statement of the title or some generic description assuming that an empty string doesn't work). |
Fair! I just didn't want |
I just tried to mention https://hub.getdbt.com/dbt-labs/audit_helper/latest/ on Discourse, and the unfurl didn't work properly because "the following oEmbed / OpenGraph tags could not be found: description, image"
Paging @krevitt who is my go-to for all these things 😬
Also, the page's title is just
dbt - Package hub
, when really it should be the name of the package. I can that pretty easily, but don't know anything about OpenGraph.The text was updated successfully, but these errors were encountered: