Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Dark and Light mode hash fragments not being respected #2476

Open
DVAlexHiggs opened this issue May 16, 2023 · 0 comments
Open

GitHub Dark and Light mode hash fragments not being respected #2476

DVAlexHiggs opened this issue May 16, 2023 · 0 comments

Comments

@DVAlexHiggs
Copy link
Contributor

DVAlexHiggs commented May 16, 2023

We've recently updated our GitHub page with a different logo for light and dark mode, so that our logo is legible regardless of the appearance the user has selected.

Unfortunately, dbt Hub does not account for this and displays both, please see below:

image

Please see here for the live version

The code in our README looks like this:

  <img src="https://user-images.githubusercontent.com/25080503/237990810-ab2e14cf-a449-47ac-8c72-6f0857816194.png#gh-light-mode-only" alt="AutomateDV">
  <img src="https://user-images.githubusercontent.com/25080503/237990915-6afbeba8-9e80-44cb-a57b-5b5966ab5c02.png#gh-dark-mode-only" alt="AutomateDV">

Here are the Github Docs on this feature

Is there any way to enable support for this on dbt Hub? I imagine it might be as simple as adding some CSS to the stylesheets.

I think, as the dbt Hub theme has a white background and this cannot be user-configured, we'd only want to show the gh-light-mode-only image.

Thanks

@DVAlexHiggs DVAlexHiggs changed the title GitHub Dark and Light mode CSS not being respected GitHub Dark and Light mode hash slugs not being respected May 16, 2023
@DVAlexHiggs DVAlexHiggs changed the title GitHub Dark and Light mode hash slugs not being respected GitHub Dark and Light mode hash fragments not being respected May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant