From b98d8384716573b781bbdd39ed24b4b05f8261de Mon Sep 17 00:00:00 2001 From: Zeeshan Ali Khan Date: Thu, 19 Sep 2024 23:06:10 +0200 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F=20zb:=20Use=20relaxed=20load?= =?UTF-8?q?=20order=20for=20serial=20number=20fetch=20&=20add?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Relaxed order is good enough here and SeqCst is an overkill. --- zbus/src/message/header.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/zbus/src/message/header.rs b/zbus/src/message/header.rs index e454fad05..df9e0405c 100644 --- a/zbus/src/message/header.rs +++ b/zbus/src/message/header.rs @@ -1,6 +1,6 @@ use std::{ num::NonZeroU32, - sync::atomic::{AtomicU32, Ordering::SeqCst}, + sync::atomic::{AtomicU32, Ordering::Relaxed}, }; use enumflags2::{bitflags, BitFlags}; @@ -131,9 +131,9 @@ assert_impl_all!(PrimaryHeader: Send, Sync, Unpin); impl PrimaryHeader { /// Create a new `PrimaryHeader` instance. pub fn new(msg_type: Type, body_len: u32) -> Self { - let mut serial_num = SERIAL_NUM.fetch_add(1, SeqCst); + let mut serial_num = SERIAL_NUM.fetch_add(1, Relaxed); if serial_num == 0 { - serial_num = SERIAL_NUM.fetch_add(1, SeqCst); + serial_num = SERIAL_NUM.fetch_add(1, Relaxed); } Self {