Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do arrowheads and edge stubs work in angular? #105

Open
gordonwoodhull opened this issue Jan 2, 2019 · 1 comment
Open

do arrowheads and edge stubs work in angular? #105

gordonwoodhull opened this issue Jan 2, 2019 · 1 comment
Labels
question

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Jan 2, 2019 •
edited
Loading

In 5f84455 we gave absolute URLs for the xlink:href of edge labels, because Angular 1 on Firefox needs this (see dc-js/dc.js#1079). 🤔

So are arrowheads and the gradients we use for edge stubs also broken in that strange environment? They also live in <defs> but we only use hash to refer to them.

(Do we care? This seems very stupid and brittle, since it means they all need to be updated whenever the URL changes, which it does, 45fd9f8.)
@gordonwoodhull
Copy link
Contributor Author

Alternately should we make absolute URLs an option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gordonwoodhull