Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeafletMarkerChart hangs when popup moves chart 2 times #1263

Closed
thebarbarian opened this issue Jan 17, 2017 · 1 comment
Closed

LeafletMarkerChart hangs when popup moves chart 2 times #1263

thebarbarian opened this issue Jan 17, 2017 · 1 comment

Comments

@thebarbarian
Copy link

I am not sure if it's a bug or my terrible JS-coding, please remove this if i messed up.

When displaying a LeafletMarkerChart and clicking a marker on the edge of the map, the creation of the textballoon will move the map slighly until it fits inside the frame. If i do this two times, i'm unable to drag the map. It's stuck.
The console gave me the following error after the map is stuck and i click a marker:
_markerList.indexOf is not a function(…)

After changing line 583 of dc-leaflet.js :
(_markerList.indexOf(_chart.filter()) !== -1 &&

into this:
(_markerList.toString().indexOf(_chart.filter()) !== -1 &&

the problem is solved. Adding the toString()-method doesn't seem to affect any of the other graphs on my dashboard.

My apologies if this isn't a bug, but it seemed to make sense to let the developers know.

@gordonwoodhull
Copy link
Contributor

This issue was moved to dc-js/dc.leaflet.js#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants