xAxisLabel / yAxisLabel modify margins

[emiljas]

I think that this code cause a lot of trouble:

_chart.yAxisLabel = function (labelText, padding) {
        if (!arguments.length) {
            return _yAxisLabel;
        }
        _yAxisLabel = labelText;
        _chart.margins().left -= _yAxisLabelPadding;
        _yAxisLabelPadding = (padding === undefined) ? DEFAULT_AXIS_LABEL_PADDING : padding;
        _chart.margins().left += _yAxisLabelPadding;
        return _chart;
    };

In my code I set margin (e.g. left margin to 10px) and then set yAxisLabel (default padding 12px).
Then I do this again for some action, but in my model margin is still 10px but it isn't true.

I hope you understand my problem. Do you agree that this code smell?

[gordonwoodhull]

I agree, that's disgusting!

Probably we should have a function that calculates the margins, that uses .margins() and _yAxisLabelPadding and whatever else. I think it could be a backward compatible change that way. (Except for changing the margins, which behavior does not need to be preserved.)

Any chance you'd like to contribute a fix?

[emiljas]

#1342 PR with fix