Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagination + sortable to dataTable #1465

Closed
tttp opened this issue Jul 9, 2018 · 3 comments
Closed

add pagination + sortable to dataTable #1465

tttp opened this issue Jul 9, 2018 · 3 comments

Comments

@tttp
Copy link
Contributor

tttp commented Jul 9, 2018

as per: https://tttp.eu
https://github.com/TechToThePeople/mep/blob/master/index.html#L494
Rationale: using an existing library (datatable is awesome) means that you duplicate a lof of the features from crossfilter that is pretty good at filtering and sorting... and that you have to draw the full table with dc, initialise the pagination/sort library (datatable) that will hide all the rows but the first page...
it is paintfully slow if you have more than a few k's of rows

@tttp
Copy link
Contributor Author

tttp commented Jul 9, 2018

@gordonwoodhull could you assign to me?
Also, what is the branch to fork? master or develop?

@gordonwoodhull
Copy link
Contributor

I still disagree with duplicating so much existing functionality. See #1391 (comment)

I'd prefer to see if there is a way to avoid the performance problems of datatables.js

e.g.
https://datatables.net/examples/data_sources/js_array

@tttp
Copy link
Contributor Author

tttp commented Jul 9, 2018

On the other hand, the datatable duplicates a lot more functionality from crossfilter than adding pagination (that is already in dc) and filtering on headers

But I see your point, and it's quite easy to keep the filtering + pagination outside of dc, let's close and if someone wants to copy paste, let's keep https://github.com/TechToThePeople/mep/blob/master/index.html#L494 as a ref and close the issue

@tttp tttp closed this as completed Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants