Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow should point forward not backward when sorted by newest #476

Open
metafraction opened this issue Nov 2, 2021 · 2 comments
Open

Arrow should point forward not backward when sorted by newest #476

metafraction opened this issue Nov 2, 2021 · 2 comments

Comments

@metafraction
Copy link
Member

metafraction commented Nov 2, 2021

when sorted by newest, the first grant shows a backward arrow and no forward arrow to navigate grants - this is fine for when sorted by oldest it would be nice to make adjustments for the arrows when sorted differently (like newest or whatever else)

@thelostone-mc
Copy link
Collaborator

Hmm i see what you're saying but this might be tricky as once you move from list to detail view ,
we don't keep track off the sort order.

  • Maintaining the state internally and using that to figure out the next grant on grant detail page might be confusing to the user. (cause they might not be aware that their change influenced this)
  • We could add a query param to ensure it makes easier to scroll through diff order but seems like an overkill IMO

Thoughts ?

@metafraction
Copy link
Member Author

yeah you could be right - wanted to bring it up

I'm fine leaving it is as is, just seems confusing that when the user sorts by newest the first one is clearly still the last one in the list (as you must scroll back to view other grants)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants