Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current Pagination scheme from Offsetbased -> keybased #75

Open
3 tasks
HenrikHL opened this issue Jun 3, 2021 · 0 comments
Open
3 tasks

Change current Pagination scheme from Offsetbased -> keybased #75

HenrikHL opened this issue Jun 3, 2021 · 0 comments

Comments

@HenrikHL
Copy link
Contributor

HenrikHL commented Jun 3, 2021

The current implementation uses offset based pagination (this was for simplicity) - change it to key based to be aligned with the Design Guide specs.

Investigate if last_page cursor, prev_page cursor should be removed. If these pages are too complex to compute we could consider removing them from the Design Guide.

Investigate the complexity of having pagination with multiple sorting columns defined.
EX: sort=name,age:desc
If it turns out that this is too complex consider updating the Design Guide to reflect this

  • change to key based pagination
  • investigate if last_page and prev_page is possible to compute
  • investigate if multiple sort columns is compatible with key based pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant