Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CargoLineItem #127

Open
nissimsan opened this issue Dec 3, 2021 · 6 comments
Open

CargoLineItem #127

nissimsan opened this issue Dec 3, 2021 · 6 comments
Assignees

Comments

@nissimsan
Copy link
Contributor

nissimsan commented Dec 3, 2021

Hi DCSA,
I'm pretty sure your CargoItem and CargoLineItem are a bit conflated. The latter only has id and shippingMarks - what's the point of having those two in isolation like that?

@nissimsan
Copy link
Contributor Author

It's the product description - not the marks and numbers - which should be line itemized.

@nissimsan
Copy link
Contributor Author

Moving descriptionOfGoods (and perhaps HSCode) into CargoLineItem I think is the best way to address this.

@raisoman
Copy link

raisoman commented Dec 9, 2021

Hi @nissimsan,

could you possibly provide an example?

@nissimsan
Copy link
Contributor Author

Bonjour @raisoman,

Yes, this is what I mean:

      "cargoItems": [
        {
          "type": "CargoItem",
          "cargoLineItems": [
            {
              "type": "CargoLineItem",
              "descriptionOfGoods": "Rollators",
              "shippingMarks": "ByAcre Age is the new Black"
            },
            {
              "type": "CargoLineItem",
              "descriptionOfGoods": "Rollators Organizer Bags",
              "shippingMarks": "ByAcre Age is the new Black"
            },
            {
              "type": "CargoLineItem",
              "descriptionOfGoods": "Rollators Backrest",
              "shippingMarks": "ByAcre Age is the new Black"
            },
            {
              "type": "CargoLineItem",
              "descriptionOfGoods": "Rollators Cane Holder Bracket",
              "shippingMarks": "ByAcre Age is the new Black"
            },
            {
              "type": "CargoLineItem",
              "descriptionOfGoods": "Rollators Cardboard Box",
              "shippingMarks": "ByAcre Age is the new Black"
            }
          ],
          "weight": 1671.9,
          "weightUnit": "KGM",
          "volume": 27.23,
          "volumeUnit": "CBM",
          "numberOfPackages": 245
        }
      ],

@HenrikHL
Copy link
Contributor

HenrikHL commented Dec 9, 2021

Would this work for you:

  "cargoItems": [
    {
      "cargoLineItems": [
        {
          "cargoLineItemID": "1",
          "shippingMarks": "Rollators"
        },
        {
          "cargoLineItemID": "2",
          "shippingMarks": "Rollators Organizer Bags"
        },
        {
          "cargoLineItemID": "3",
          "shippingMarks": "Rollators Backrest"
        },
        {
          "cargoLineItemID": "4",
          "shippingMarks": "Rollators Cane Holder Bracket"
        },
        {
          "cargoLineItemID": "5",
          "shippingMarks": "Rollators Cardboard Box"
        }
      ],
      "descriptionOfGoods": "Rollator accessories",
      "HSCode": "8713100000",
      "weight": 1671.9,
      "volume": 27.23,
      "weightUnit": "KGM",
      "volumeUnit": "CBM",
      "numberOfPackages": 245
    }

Check the HSCode ;-)

@raisoman
Copy link

@nissimsan, in your example, shippingMarks is the same in all the cargoLineItems. Would that mean that they would fit better at cargoItem level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@raisoman @HenrikHL @nissimsan and others