Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor links on Agenda #239

Open
antonjb opened this issue Feb 5, 2020 · 0 comments
Open

Sponsor links on Agenda #239

antonjb opened this issue Feb 5, 2020 · 0 comments
Labels
a11y accessibility issues that need attention good first issue Good for newcomers

Comments

@antonjb
Copy link
Contributor

antonjb commented Feb 5, 2020

From the a11y review that was performed

Duplicate link text for some screenreader users, due to the title attributes which are not consistently presented cross-browser/cross-screenreader. Also no indication of opening in a new window – new windows are difficult for some users to manage and a warning gives them the opportunity to decide what to do about it.

Recommendation: Remove the title attributes from the links and append ", opens in a new window" to the existing alt values. Ideally, you'd use a "new window" icon with appropriate alt content but I've never yet met a sponsor who liked that, so visually-hidden text will do.

Acceptance criteria is to action the recommendation.

image

This is the area of the agenda

@antonjb antonjb added good first issue Good for newcomers a11y accessibility issues that need attention labels Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y accessibility issues that need attention good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant