Shouldn't HTTP(S)_EXPOSE use router_http_port and router_https_port?

[HeineDeelstra]

I'm was trying to run a ddev project using ddev-varnish on another router_http_port/router_https_port than the default via the project's config.yaml and noticed that the varnish container hardcodes the 80/443 ports. After changing HTTPS_EXPOSE and HTTP_EXPOSE in docker-compose.varnish.yaml's environment to:

  - HTTPS_EXPOSE=${DDEV_ROUTER_HTTPS_PORT}:80,8026:8025
  - HTTP_EXPOSE=${DDEV_ROUTER_HTTP_PORT}:80,8025:8025

and restarting, varnish started working for this project.

[rfay]

It would be reasonable for this to automatically derive the dynamic ports being used by DDEV, but I'm not sure how ambitious we want to be here. Since the HTTP_EXPOSE stuff can change and the router_http_port can change based on DDEV config, it would require something actively to happen with the varnish docker-compose.varnish.yaml here. Not sure how easy that would be to do. Contributions welcome.

[rfay]

Updated title to reflect what I think you were saying, let me know if I got it right.