Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when merging tbl_summary() with tbl_svysummary() #1626

Open
ddsjoberg opened this issue Apr 14, 2024 · 3 comments
Open

Bug when merging tbl_summary() with tbl_svysummary() #1626

ddsjoberg opened this issue Apr 14, 2024 · 3 comments

Comments

@ddsjoberg
Copy link
Owner

Check out this SO issue for details: https://stackoverflow.com/questions/78323493

The problem is that survey N is a double and non-survey N is an integer, and they cannot be mixed upon merging.

@ddsjoberg
Copy link
Owner Author

I think we could use match() instead of dplyr::rows_update(), which requires type matching.

@larmarange
Copy link
Collaborator

👍

@ddsjoberg ddsjoberg added this to the v2.0.0 milestone Jun 23, 2024
@ddsjoberg ddsjoberg added the v2.0 🤞🤞 A nice-to-have for the v2.0 release label Jun 26, 2024
@ddsjoberg ddsjoberg removed the v2.0 🤞🤞 A nice-to-have for the v2.0 release label Jul 11, 2024
@ddsjoberg
Copy link
Owner Author

Perhaps the most general solution to this issue would be to make the column a list column?

@ddsjoberg ddsjoberg removed this from the v2.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants