Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questioning add_stat_label() #1670

Open
ddsjoberg opened this issue May 19, 2024 · 0 comments
Open

Questioning add_stat_label() #1670

ddsjoberg opened this issue May 19, 2024 · 0 comments

Comments

@ddsjoberg
Copy link
Owner

Couple of things I don't like about this function:

  • handling of continuous2 label changes
    • what we're doing to the continuous2 label is different from everything else. is this the best place to make these kinds of changes?
    • When continuous2 has many rows, it is very annoying to list every single statistic that doesn't change, just to modify one of them. There must be a better API for this.
  • we now have functionality in tbl_summary() to change the missing row's statistics, but there is no way to change the label for the missing row.

I am not sure if this should be a new function(s), or we can modify the API of this function. But I think changes are warrented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant