Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modify_table_styling() checks? #1671

Open
ddsjoberg opened this issue May 19, 2024 · 0 comments
Open

Add modify_table_styling() checks? #1671

ddsjoberg opened this issue May 19, 2024 · 0 comments

Comments

@ddsjoberg
Copy link
Owner

Generally, this function does not perform checks on user input. It's expected that that function is primarily used by devs to create new tabling functions, and the inputs should be verified prior to calling the function OR the dev should know what is accepted/not accepted.

Also, nearly every feature that is modifiable here has a sister function that has a nicer API, and those functions have checks....

By not adding checks here, the internal functions could be mildly quicker to run. But is that worth it?

If we do add them, we should move the checks from the sister functions, and let them be handled by this function? Although, the messaging would be difficult to get exactly right....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant