Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tbl_custom_summary() #1699

Open
ddsjoberg opened this issue May 31, 2024 · 2 comments
Open

Review tbl_custom_summary() #1699

ddsjoberg opened this issue May 31, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@ddsjoberg
Copy link
Owner

ddsjoberg commented May 31, 2024

The tbl_custom_summary() function was merged in PR #1698

Can you please review to ensure there are no unknown regressions in functionality.

There are two known regressions:

  • continuous_summary() is currently deprecated. The deprecation note indicates that similar functionality is available in tbl_continuous().
  • The default formatting performed for the displayed statistics are numeric formatters, e.g. 45.123123 -> '45'. When the statistic is character, the user needs to specify a formatting function (via digits argument) that works with characters, e.g. as.character. This behaviour mimics what occurs in tbl_summary(). But we could move things around to make this work.... 🤔
@ddsjoberg ddsjoberg added the v2.0 label May 31, 2024
@ddsjoberg ddsjoberg added this to the v2.0.0 milestone Jun 23, 2024
@ddsjoberg
Copy link
Owner Author

The default formatting performed for the displayed statistics are numeric formatters, e.g. 45.123123 -> '45'. When the statistic is character, the user needs to specify a formatting function (via digits argument) that works with characters, e.g. as.character. This behaviour mimics what occurs in tbl_summary(). But we could move things around to make this work.... 🤔

FYI @larmarange this was fixed in #1806

@larmarange
Copy link
Collaborator

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants