Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "keep running in background after all tabs were closed" option #396

Open
IvoryJam opened this issue Apr 4, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@IvoryJam
Copy link

IvoryJam commented Apr 4, 2023

yakuake does this and it makes it faster to open after closing with exit or the shortcut ctrl-d

@IvoryJam IvoryJam added the enhancement New feature or request label Apr 4, 2023
@pesader
Copy link
Contributor

pesader commented Apr 20, 2023

@amezin Do you have an idea of how to implement that? I also want this feature, so I could submit a PR if you give me a general direction :)

@amezin
Copy link
Member

amezin commented Apr 20, 2023

Changes outside application.js should not be necessary.

Currently, the code there assumes that the window always exists. So it should be modified to work even when this.window is null (and also it should likely create the window in activate() instead of startup()). In particular, Gio.Actions shouldn't be simply copied from the window object, instead, proxy actions (that also create the window when necessary) should be created.

To keep the app running - see https://gjs-docs.gnome.org/gio20/gio.application#method-hold

@amezin
Copy link
Member

amezin commented Sep 23, 2023

Currently, the code there assumes that the window always exists. So it should be modified to work even when this.window is null (and also it should likely create the window in activate() instead of startup()). In particular, Gio.Actions shouldn't be simply copied from the window object, instead, proxy actions (that also create the window when necessary) should be created.

All of this is already implemented - to make D-Bus activation work

Also, Gio.Application has a inactivity-timeout property - maybe setting that to a large value should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants