Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[toltec rm2fb 1.0.1-1] 2.6 Feedback #56

Closed
Pemo11235 opened this issue Mar 21, 2021 · 8 comments
Closed

[toltec rm2fb 1.0.1-1] 2.6 Feedback #56

Pemo11235 opened this issue Mar 21, 2021 · 8 comments

Comments

@Pemo11235
Copy link

I just tried new rm2fb toltec pack and this works greatly. GJ !

I just want to inform that the new pinch to zoom its kinda laggy and a bit inaccurate. The input itself is right but the screen doesn't show exactly where I am when in moving the 2 fingers during the gesture.
I hope that i express my self, is easier to watch lol

I guess is the limit of framebuffer server/client solution.

p.s. Thanks for the great work all of you do for community!
@raisjn
Copy link
Collaborator

raisjn commented Mar 21, 2021

thank you for reporting! i haven't upgraded to 2.6 yet, so i haven't seen all these cool features, but i think ddvk and matteo are on 2.6

it sounds like the waveforms are not well matched and they are using something faster than what we do? (or they use wait ioctl or other ioctls?)

@timower
Copy link
Collaborator

timower commented Mar 24, 2021

It's a problem with the server, I'm getting:

Unable to complete update: invalid waveform ( 6 )
Unable to complete update: invalid waveform ( 6 )
Unable to complete update: invalid waveform ( 6 )
....

when zooming and panning. I suspect the swtcon in xochitl was updated but not in remarkable-shutdown. Causing unknown waveform modes.

@raisjn
Copy link
Collaborator

raisjn commented Mar 24, 2021

that's very interesting and unfortunate. i was somewhat hoping the SWTCON is not changing (and us always having the shutdown binary if necessary), but now it looks like they can break SWTCON compat between versions :-(

please let us know if it works when using xochitl as the host for rm2fb!

@ddvk
Copy link
Owner

ddvk commented Mar 24, 2021

they probably didnt update the shutdown binary

@timower
Copy link
Collaborator

timower commented Mar 24, 2021

Using xochitl as host for the server works. I was getting segfaults but it seems unrelated.

@mehalter
Copy link

mehalter commented Apr 2, 2021

I'm having some issues popping up after the update that I'm not sure if they should go here or in other places. I noticed that after the update remux stopped working which relies on rm2fb. When I start it manually with the command remux it shows a warning that I don't have rm2fb installed. I am also running into a weird issue with Koreader where the xochitl is bleeding through the UI and I get this weird frankenstein UI where touch events are going to both koreader and xochitl. I'm not sure if these issues should be opened with the respective packages or if this could be a result of something with rm2fb. Let me know what you think or if there's anything I could do to help identify the problem. Sorry in advanced if this comment is misplaced!

@mehalter
Copy link

mehalter commented Apr 2, 2021

Ignore the previous comment, I got it all fixed and working. rm2fb is working great on the new version!

matteodelabre added a commit to toltec-dev/toltec that referenced this issue Apr 2, 2021
@matteodelabre
Use xochitl instead of remarkable-shutdown in rm2fb-server
1bd9582 
In the last software relase (2.6), new waveform modes were added to
xochitl to make the pinch-to-zoom feature work. Unfortunately, the
remarkable-shutdown binary was not updated to support those new
waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a
less smooth experience than without rm2fb, since the screen gets
refreshed less frequently during the gesture.

See:

* <#322 (comment)>
* <ddvk/remarkable2-framebuffer#56>

To address this issue, this PR changes the rm2fb-server to preload the
`/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in
both the `rm2fb-server` command and `rm2fb.service`.

A start condition is added to `rm2fb.service` to only start if the
librm2fb_server library actually exists on the filesystem. This is to
avoid having two concurrent xochitl processes running, as the loader
ignores non-existent files provided in LD_PRELOAD.

Test plan:

* Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of
  the pinch-to-zoom gesture, and make sure no message of the form
  `Unable to complete update: invalid waveform ( 6 )` appears in the
  server process.
* Check that the display continuously updates when using the
  pinch-to-zoom gesture, even if the `rm2fb.service` service is running
  and xochitl is started with `rm2fb-client xochitl`.
* Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart
  `rm2fb.service`. The service should not start. Make sure that there’s
  no duplicate `xochitl` process in this case.
@matteodelabre matteodelabre mentioned this issue Apr 2, 2021
Merged
matteodelabre added a commit to toltec-dev/toltec that referenced this issue Apr 2, 2021
@matteodelabre
Use xochitl instead of remarkable-shutdown in rm2fb-server (#325)
12e6fb4 
In the last software relase (2.6), new waveform modes were added to
xochitl to make the pinch-to-zoom feature work. Unfortunately, the
remarkable-shutdown binary was not updated to support those new
waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a
less smooth experience than without rm2fb, since the screen gets
refreshed less frequently during the gesture.

See:

* <#322 (comment)>
* <ddvk/remarkable2-framebuffer#56>

To address this issue, this PR changes the rm2fb-server to preload the
`/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in
both the `rm2fb-server` command and `rm2fb.service`.

This PR also contains a patch to prevent rm2fb-server from appearing as xochitl in process lists. This is done by overwriting `argv[0]` after the library is initialized. This is necessary to prevent remux from mistakenly killing rm2fb-server.

A start condition is added to `rm2fb.service` to only start if the
librm2fb_server library actually exists on the filesystem. This is to
avoid having two concurrent xochitl processes running, as the loader
ignores non-existent files provided in LD_PRELOAD.

Test plan:

* Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of
  the pinch-to-zoom gesture, and make sure no message of the form
  `Unable to complete update: invalid waveform ( 6 )` appears in the
  server process.
* Check that the display continuously updates when using the
  pinch-to-zoom gesture, even if the `rm2fb.service` service is running
  and xochitl is started with `rm2fb-client xochitl`.
* Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart
  `rm2fb.service`. The service should not start. Make sure that there’s
  no duplicate `xochitl` process in this case.
@matteodelabre
Copy link
Collaborator

Since this is solved by running the server on xochitl instead of remarkable-shutdown, I’ll close this issue. The rm2fb package in Toltec was recently (toltec-dev/toltec#325) updated with this change, and should land in stable in the next merge.

matteodelabre added a commit that referenced this issue Apr 8, 2021
@matteodelabre
server: Change instructions to use xochitl & set process name to rm2f…
f1614c8 
…b-server

See #56 and toltec-dev/toltec#325 for context.
@matteodelabre matteodelabre mentioned this issue Apr 8, 2021
Merged
raisjn pushed a commit that referenced this issue Apr 10, 2021
@matteodelabre
[server] change instructions to use xochitl & set process name to rm2…
5786f0e 
…fb-server (#59)

See #56 and toltec-dev/toltec#325 for context.
danshick pushed a commit to danshick/toltec that referenced this issue May 5, 2021
@matteodelabre @danshick
Use xochitl instead of remarkable-shutdown in rm2fb-server (toltec-de…
aadaead 
…v#325)

In the last software relase (2.6), new waveform modes were added to
xochitl to make the pinch-to-zoom feature work. Unfortunately, the
remarkable-shutdown binary was not updated to support those new
waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a
less smooth experience than without rm2fb, since the screen gets
refreshed less frequently during the gesture.

See:

* <toltec-dev#322 (comment)>
* <ddvk/remarkable2-framebuffer#56>

To address this issue, this PR changes the rm2fb-server to preload the
`/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in
both the `rm2fb-server` command and `rm2fb.service`.

This PR also contains a patch to prevent rm2fb-server from appearing as xochitl in process lists. This is done by overwriting `argv[0]` after the library is initialized. This is necessary to prevent remux from mistakenly killing rm2fb-server.

A start condition is added to `rm2fb.service` to only start if the
librm2fb_server library actually exists on the filesystem. This is to
avoid having two concurrent xochitl processes running, as the loader
ignores non-existent files provided in LD_PRELOAD.

Test plan:

* Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of
  the pinch-to-zoom gesture, and make sure no message of the form
  `Unable to complete update: invalid waveform ( 6 )` appears in the
  server process.
* Check that the display continuously updates when using the
  pinch-to-zoom gesture, even if the `rm2fb.service` service is running
  and xochitl is started with `rm2fb-client xochitl`.
* Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart
  `rm2fb.service`. The service should not start. Make sure that there’s
  no duplicate `xochitl` process in this case.
LinusCDE pushed a commit to toltec-dev/toltec that referenced this issue Jun 3, 2021
@matteodelabre @LinusCDE
Use xochitl instead of remarkable-shutdown in rm2fb-server (#325)
90bc24f 
In the last software relase (2.6), new waveform modes were added to
xochitl to make the pinch-to-zoom feature work. Unfortunately, the
remarkable-shutdown binary was not updated to support those new
waveforms. As a consequence, using pinch-to-zoom with rm2fb results in a
less smooth experience than without rm2fb, since the screen gets
refreshed less frequently during the gesture.

See:

* <#322 (comment)>
* <ddvk/remarkable2-framebuffer#56>

To address this issue, this PR changes the rm2fb-server to preload the
`/usr/bin/xochitl` binary instead of `/usr/bin/remarkable-shutdown` in
both the `rm2fb-server` command and `rm2fb.service`.

This PR also contains a patch to prevent rm2fb-server from appearing as xochitl in process lists. This is done by overwriting `argv[0]` after the library is initialized. This is necessary to prevent remux from mistakenly killing rm2fb-server.

A start condition is added to `rm2fb.service` to only start if the
librm2fb_server library actually exists on the filesystem. This is to
avoid having two concurrent xochitl processes running, as the loader
ignores non-existent files provided in LD_PRELOAD.

Test plan:

* Manually run `rm2fb-server` and `rm2fb-client xochitl`, make use of
  the pinch-to-zoom gesture, and make sure no message of the form
  `Unable to complete update: invalid waveform ( 6 )` appears in the
  server process.
* Check that the display continuously updates when using the
  pinch-to-zoom gesture, even if the `rm2fb.service` service is running
  and xochitl is started with `rm2fb-client xochitl`.
* Remove the `/opt/lib/librm2fb_server.so.1` symlink and restart
  `rm2fb.service`. The service should not start. Make sure that there’s
  no duplicate `xochitl` process in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@matteodelabre @mehalter @timower @ddvk @Pemo11235 @raisjn