Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible macro removal (GetAMSSize) #3

Open
kkofler opened this issue Oct 2, 2013 · 0 comments
Open

Incompatible macro removal (GetAMSSize) #3

kkofler opened this issue Oct 2, 2013 · 0 comments

Comments

@kkofler
Copy link

kkofler commented Oct 2, 2013

Commit 56510f7 removes a macro from your fork of TIGCCLIB, breaking source compatibility. Functions and macros in TIGCCLIB can only be deprecated, never removed. And in this case, if you think the macro is not good enough, the proper fix is to replace it with a function that works more reliably, but most definitely not to just remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkofler