Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] DCLMF24 | Video/stream reset/delay #2880

Open
DafGreco opened this issue Nov 25, 2024 · 2 comments
Open

[QA] DCLMF24 | Video/stream reset/delay #2880

DafGreco opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
2-medium Important issues we must fix, but not as important as high! bug Something isn't working

Comments

@DafGreco
Copy link
Collaborator

Build version:

0.45.0

Issue Description:

Some users experience the video stream reset or having delay issues on the main stage

STR:

  1. Open 0.45.0
  2. Go to the main stage of the Music Festival
  3. Validate that some users experience some delay on the video when it starts

Actual Result:

Video/stream reset/delay

✔️ Expected Result:

The stream should not reset or have delay issues when streaming

Repro Index:

2/5

Additional Notes:

This issue happened on Macos mainly

@DafGreco DafGreco added bug Something isn't working 2-medium Important issues we must fix, but not as important as high! new Issues to triage labels Nov 25, 2024
@m3taphysics m3taphysics removed the new Issues to triage label Nov 25, 2024
@dalkia
Copy link
Collaborator

dalkia commented Nov 27, 2024

This is 100% reprodueceable locally

Checkout https://github.com/decentraland-scenes/dcl_music_fest_2024_stage

In scheduleSetup.ts, do the following changes

image

This will make the show start at the 500 seconds mark. If you open in web, you can see that the shows starts at that point

But if you open in alpha, the show starts from the beggining

@QThund
Copy link
Collaborator

QThund commented Nov 28, 2024

This is 100% reprodueceable locally

Checkout https://github.com/decentraland-scenes/dcl_music_fest_2024_stage

In scheduleSetup.ts, do the following changes
image

This will make the show start at the 500 seconds mark. If you open in web, you can see that the shows starts at that point

But if you open in alpha, the show starts from the beggining

The current issue is different. The symptoms are the same but not the cause. The bug was filed before the Video prioritization PR was merged. By that time, the bug was very hard to reproduce and the cause is still unknown (will share some details below). But the current problem is due to a corner case not addressed by the merged PR. I think a different issue should be created to handle a different problem (or I can send a PR without filing a new bug, as I already fixed it).

Regarding the original bug, this is what we know:
-It is only reproducible when connecting to the scene in production, never locally.
-The scene sends the correct time value.
-The time value is stored in a PBVideoPlayer structure (Position field), properly filled in the scene.
-The data structure arrives the renderer without that field filled, sometimes (take a look at MediaPlayerExtensions.SetPlaybackPropertiesAsync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium Important issues we must fix, but not as important as high! bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants