Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator in G1 in BlindSign #107

Closed
alessandroguggino opened this issue Apr 20, 2022 · 3 comments · Fixed by #108
Closed

Add generator in G1 in BlindSign #107

alessandroguggino opened this issue Apr 20, 2022 · 3 comments · Fixed by #108

Comments

@alessandroguggino
Copy link
Contributor

From the BlindSign function:

6. b = commitment + h0 \* s'' + h\[j1\] \* msg\[1\] + ... + h\[jK\] \* msg\[K\]

We should add P1, the generator point in G1, in order to make a valid signature after the unblinding:
b = commitment + P1 + h0 * s'' + h[j1] * msg[1] + ... + h[jK] * msg[K]

If you agree with me I will open a pull request where I will change b as proposed and add P1's definition into the Terminology section.

@BasileiosKal
Copy link
Contributor

BasileiosKal commented Apr 20, 2022

Yeap! That makes sense to me.

@alessandroguggino
Copy link
Contributor Author

I have seen that in the main draft P1 is defined in Notation instead of Terminology. But there is no Notation section. May I add it and modify the structure of the document following the one of the main draft?
This is related to issue #90.
Otherwise, I just change the calculation of b for now.

@tplooker
Copy link
Member

Yes @alessandroguggino as documented in #90 feel free to update it for consistency. I would suggest instead of duplicating the terminology you could just reference the core draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants